Add JPMS support using Automatic-Module-Name#154
Add JPMS support using Automatic-Module-Name#154mechite wants to merge 1 commit intoapache:masterfrom mechite:master-1
Conversation
Signed-off-by: Mechite <contact@mechite.com>
It seems like this is already done - is this configuration not enough/not functioning correctly? (There isn't really a reason not to give a full module-info anyways) |
|
It is not - I have currently a modified JAR deployed to my local repository with I do agree though - dmlloyd/module-info can be used to generate the file without dropping support for Java <8, or alternatively a In any case, |
|
There is also https://github.com/moditect/moditect, which i've used in PRs to other repos. Would maybe want to/have to set that up in |
|
Moditect will be used for the next release, see the definition in commons-parent. |
|
When is this release scheduled? |
There is no schedule but it is on my to-do list. |
|
Closing: module info file generated by parent POM. |
…d1af9de already removed usage of it
This was used as a method of allowing sub-modules to access the local
repository ("stellar.depot", which was used to house a `commons-logging`
version that was modified for JPMS support - was removed due to [1]).
[1] - apache/commons-logging#154 (comment)
Signed-off-by: Mechite <contact@mechite.com>
Understandably this project is unmaintained and pointless for a long time. However, many libraries, especially proprietary ones, still make use of
commons-logging.It is ideal if we can simply reserve the
org.apache.commons.loggingmodule name so that it is safe to publish these artifacts, and this artifact doesn't prevent migration of ancient projects to JPMS.