JUnit5 assertThrows TestNtpPacket#119
Closed
nhojpatrick wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
nhojpatrick
force-pushed
the
junit5-assertThrows-TestNtpPacket
branch
from
0c7a150 to
fe0a633
Compare
garydgregory
requested changes
Nov 5, 2022
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
The local variable is not needed and feels like it just clutters up the code.
Member
|
@nhojpatrick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.