Add MockTcpServer, DaytimeTCPClient integration tests

[jkbkupczyk]

• Adds MockTcpServer - base class for all other TCP Server impls, e.g. we can have MockDiscardTCPServer to test DiscardTCPClient or MockEchoTCPServer to test EchoTCPClient
• Adds MockDaytimeTCPServer that uses the given clock to mock returned daytime string
• Adds DaytimeTCPClient integration tests

FYI
@garydgregory @kinow @sebbASF

[garydgregory]

@jkbkupczyk
Thank you for PR.
Please add a brief class level Javadoc to each new class.
Files should end in an empty line.

[jkbkupczyk]

@jkbkupczyk Thank you for PR. Please add a brief class level Javadoc to each new class. Files should end in an empty line.

Thank you @garydgregory for review :)
I added missing Jacadocs and rebased onto master.

[jkbkupczyk]

Hi @garydgregory, any new comments regarding this PR?

[garydgregory]

Don't change the style of the Javadoc please. A getter "Gets...".

[jkbkupczyk]

I pushed that code by accident, and I already reverted it back. In pull #173 (that part) is fixed

[garydgregory]

-1 as the PR stands today: The PR does not test anything new that isn't already tested.
Before and after this PR, the code coverage is the same at: 40% instructions / 31% branches.
Run mvn clean site -Pjacoco then open target/site/jacoco/index.html
Or am I missing something?

[jkbkupczyk]

-1 as the PR stands today: The PR does not test anything new that isn't already tested. Before and after this PR, the code coverage is the same at: 40% instructions / 31% branches. Run mvn clean site -Pjacoco then open target/site/jacoco/index.html Or am I missing something?

Hi, @garydgregory
I ran mvn clean site -Pjacoco both on master and mock_tcp_test_server_daytimetcpclient_tests and these are the results I've got:

master

mock_tcp_test_server_daytimetcpclient_tests

did you check site/jacoco/org.apache.commons.net.daytime/DaytimeTCPClient.html?

[garydgregory]

@jkbkupczyk
Well, it works for me now locally. Merged! Sorry about the delay.