Closed
Conversation
Followed the coding conventions of Apache Commons Net. Improved comments.
Umoxfo
force-pushed
the
NET-629
branch
4 times, most recently
from
2b724d3 to
c4cbf7c
Compare
The method rangeCheck, pop, and format of SubnetUtils was moved to SubnetInfo in the subnet package. Added asInteger, getCidrSignature, and getAllAddresses methods of SubnetUtils.SubnetInfo to SubnetInfo in the subnet package. Changed the parameter type of isInRange from short array to integer array. Improved comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class has a few common methods, which are rangeCheck, pop, and format, and two ways to generate subnet summary information from the existing SubnetUtils class constructors.