NUMBERS-194: GCD JavaDoc mention coprimes check#133
Closed
orionlibs wants to merge 6 commits intoapache:masterfrom
orionlibs:NUMB-194]-JavaDoc-coprime-ArithmeticUtils-gcd
Closed
NUMBERS-194: GCD JavaDoc mention coprimes check#133orionlibs wants to merge 6 commits intoapache:masterfrom orionlibs:NUMB-194]-JavaDoc-coprime-ArithmeticUtils-gcd
orionlibs wants to merge 6 commits intoapache:masterfrom
orionlibs:NUMB-194]-JavaDoc-coprime-ArithmeticUtils-gcd
Conversation
…n be used to determine if 2 numbers are relatively prime or coprime
It explains how GCD can be used to determine if 2 numbers are relatively prime or coprime
…://github.com/orionlibs/commons-numbers into NUMB-194]-JavaDoc-coprime-ArithmeticUtils-gcd
aherbert
changed the title
aherbert
reviewed
Jul 13, 2023
| * for the special cases above.</li> | ||
| * <li>The invocation {@code gcd(0, 0)} is the only one which returns | ||
| * {@code 0}.</li> | ||
| * <li>gcd can be used to determine if two numbers are relatively prime. |
Contributor
There was a problem hiding this comment.
This has been added as a special case. It is not a special case, it is a usage example. It should be moved to a new paragraph, e.g.
<p>Two numbers are relatively prime, or coprime, if their gcd is 1.
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage 99.14% 99.14%
Complexity 1681 1681
=========================================
Files 65 65
Lines 4305 4305
Branches 854 854
=========================================
Hits 4268 4268
Misses 10 10
Partials 27 27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NUMB-194 Changed JavaDoc of the GCD methods to mention that they can be used to determine if 2 numbers are relatively prime or coprime