JUnit v4.13.1

[nhojpatrick]

Upgrade to JUnit v4.13.1

[garydgregory]

Please make sure you update changes.xml. Gary

…

On Thu, Dec 24, 2020, 04:32 Lukasz Lenart ***@***.***> wrote: Merged #9 <#9> into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJB6N4A4M6OPEK3HGD7OZ3SWMDDRANCNFSM4SL6FJTA> .

[lukaszlenart]

Even if this is a test dependency and it won't affect users?

[garydgregory]

Even if this is a test dependency and it won't affect users?

Absolutely IMO, some users are also developers. Consider that are two categories of "users" here: users of the APIs and contributors to the component.

[lukaszlenart]

Is there any guideline what should be included in changes.xml? does Maven plugins should also be included? Should I create a JIRA ticket for each?

[garydgregory]

I do not create Jira tickets for these kind of changes, I just don't see the need. If the changes file is updated then the release notes will show the changes, which is what matters most IMO. We do get a Jira report generated with the site but that is different and does not end up in the release notes. I document all updates. Think of it as transparency, why would you hide the update? I don't like to tell people to look at the git history when we can provide this information as part of our workflow. Gary

…

On Fri, Dec 25, 2020, 05:51 Lukasz Lenart ***@***.***> wrote: Is there any guideline what should be included in changes.xml? does Maven plugins should also be included? Should I create a JIRA ticket for each? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJB6NYVPGD5C5CSLEYR5DDSWRVDLANCNFSM4SL6FJTA> .

[lukaszlenart]

So this means the ultimate source of truth (changes) is changes.xml?

[garydgregory]

Well, yes, unless you want to go through the git history. Gary

…

On Sat, Dec 26, 2020, 04:32 Lukasz Lenart ***@***.***> wrote: So this means the ultimate source of truth (changes) is changes.xml? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJB6N6J6ZNGSZ6EDKNQX3DSWWUS7ANCNFSM4SL6FJTA> .