Skip to content

[TEXT-184] simplify if in CaseUtils#134

Merged
garydgregory merged 1 commit intoapache:masterfrom
xenoamess-fork:simplify_if_in_CaseUtils
Jul 21, 2020
Merged

[TEXT-184] simplify if in CaseUtils#134
garydgregory merged 1 commit intoapache:masterfrom
xenoamess-fork:simplify_if_in_CaseUtils

Conversation

@XenoAmess
Copy link
Contributor

as title

@XenoAmess XenoAmess changed the title simplify if in CaseUtils [TEXT-184] simplify if in CaseUtils Jul 21, 2020
@coveralls
Copy link

coveralls commented Jul 21, 2020

Coverage Status

Coverage decreased (-0.0005%) to 98.672% when pulling 24b96ca on XenoAmess:simplify_if_in_CaseUtils into af2e6b1 on apache:master.

if (outOffset == 0) {
capitalizeNext = false;
}
capitalizeNext = (outOffset != 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for parentheses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garydgregory OK, parentheses eliminated.

@XenoAmess XenoAmess force-pushed the simplify_if_in_CaseUtils branch from 14d1a5d to 24b96ca Compare July 21, 2020 13:46
@garydgregory garydgregory merged commit e104458 into apache:master Jul 21, 2020
asfgit pushed a commit that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants