added cp1252 escapes

[ifly6]

In EntityArrays, added escape map for CP-1252 encoding and unescape mapping. Added to StringEscapeUtils methods to escape them, preserving existing ESCAPE_HTML4 functionality.

Functionality added in response to bug report https://issues.apache.org/jira/browse/TEXT-192.

[ifly6]

I've never worked on this project before, could someone tell me what is going on?

[garydgregory]

This PR is missing unit tests.

[ifly6]

This PR is missing unit tests.

I don't know anything about how to build the project locally or how to fix the unit tests. Looking at the logs for the build, it seems that there's some counter which tallies new HashMap<>() calls and initialMap.put calls. I don't know why the test is set up this way, but I think it implies that the way the CP1252 map variable is set up, which uses new HashMap<>(ISO8859_1_ESCAPE) will always raise an error.

[coveralls]

Coverage increased (+0.007%) to 98.694% when pulling 5fb8fc7 on ifly6:master into 193c6c4 on apache:master.

[garydgregory]

I see a new map with dozens of new entries but you are only testing a single value? Am I reading this right or are all the other map entries somehow also tested?

[ifly6]

I tested a single value because the tests seem to test only a few values; adding an exhaustive number of tests seems mostly just to reproduce the existing map.

That said, thinking about how the library handles numeric escapes, I don't think it solves the initial problem that led me towards creating this pull request – translating something like “ to “ or ‰ to ‰ – so I've closed it.

[kinow]

Hi @ifly6 only had time to look at your PR now, sorry. Feel free to open a new one if you have another solution for the Windows 1252 charset issue 👍 Thanks!

[ifly6]

Hi @ifly6 only had time to look at your PR now, sorry. Feel free to open a new one if you have another solution for the Windows 1252 charset issue 👍 Thanks!

Thanks for looking at it; I think the actual way forward would be something to do with changing the numeric unescaper in Commons text to decode certain ranges as Windows-1252 instead treating them as Unicode. I'm not sure right now how to implement it in a manner consistent with the existing code base.

[ifly6]

Hi @ifly6 only had time to look at your PR now, sorry. Feel free to open a new one if you have another solution for the Windows 1252 charset issue 👍 Thanks!

I think I found a working way to get the NumericUnescaper to work with the CP-1252 section; should I create a new pull request or wait for someone to get back to me?

[kinow]

Feel free to create a new PR, or re-open thos one if you will build up on the work you've already done hhhere