Skip to content

Minor Improvements #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garydgregory merged 2 commits into from
Jan 17, 2021
Merged

Minor Improvements #196

garydgregory merged 2 commits into from
Jan 17, 2021

Conversation

@arturobernalg
Copy link
Member

@arturobernalg arturobernalg commented Jan 17, 2021

  • Remove redundant initializer
  • Use Empty array

@arturobernalg
Minor Improvement:
0be8d98 
* Remove redundant initializer
*  Use Empty array
garydgregory
garydgregory requested changes Jan 17, 2021
View reviewed changes
src/main/java/org/apache/commons/text/StrTokenizer.java Outdated
/** Whether to ignore empty tokens. */
private boolean ignoreEmptyTokens = true;

private static final String[] EMPTY_STRING_ARRAY = new String[0];
Copy link
Member

@garydgregory garydgregory Jan 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, reuse ArrayUtils.

Copy link
Member Author

@arturobernalg arturobernalg Jan 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Changed for ArrayUtils.EMPTY_STRING_ARRAY

src/main/java/org/apache/commons/text/StringTokenizer.java Outdated
/** Whether to ignore empty tokens. */
private boolean ignoreEmptyTokens = true;

private static final String[] EMPTY_STRING_ARRAY = new String[0];
Copy link
Member

@garydgregory garydgregory Jan 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, reuse ArrayUtils.

Copy link
Member Author

@arturobernalg arturobernalg Jan 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed for ArrayUtils.EMPTY_STRING_ARRAY

@garydgregory garydgregory changed the title Minor Improvement: Minor Improvements Jan 17, 2021
@garydgregory garydgregory merged commit 29b60f5 into apache:master Jan 17, 2021
@coveralls
Copy link

coveralls commented Jan 17, 2021

Coverage Status

Coverage decreased (-0.0007%) to 98.687% when pulling 1cab6c0 on arturobernalg:feature/minor_improvements into f0f6347 on apache:master.

asfgit pushed a commit that referenced this pull request Jan 17, 2021
Minor Improvements #196.
85c5ce0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garydgregory garydgregory garydgregory requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arturobernalg @coveralls @garydgregory