JUnitj v5 more progression #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhojpatrick
force-pushed
the
feature/junit-v5-static-imports
branch
from
ce4c7ab to
7ae30ef
Compare
nhojpatrick
force-pushed
the
feature/junit-v5-static-imports
branch
3 times, most recently
from
8fd83af to
a396ef7
Compare
Member
|
@nhojpatrick Note that the tests are faiing. |
(cherry picked from commit 19bd187d6b5a099e2c46862f0bd60f0cab983437)
(cherry picked from commit 8bd6e0b5560d1ec19fa74244a8fbcff321727f8f)
nhojpatrick
force-pushed
the
feature/junit-v5-static-imports
branch
from
a396ef7 to
80b677e
Compare
Contributor
Author
|
@garydgregory Have removed failing tests as I couldn't quickly fix, will get in the next batch. |
garydgregory
reviewed
Mar 5, 2022
| import junit.framework.TestResult; | ||
|
|
||
| public class RunTest { | ||
|
|
Member
There was a problem hiding this comment.
In the future, please don't mix in style changes, it makes the PR larger and it takes longer to review.
garydgregory
approved these changes
Mar 5, 2022
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
See 1 comment, no style changes, it's annoying to review 167 files when so many contain ONLY adding or removing blank lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything with this pr and PR #242 now migrated to JUnit v5, unless it depends upon junit.framework.TestCase.