test(java): remove duplicate code in BackButtonMultipageTest #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
approved these changes
Oct 6, 2020
Contributor
raphinesse
left a comment
raphinesse
left a comment
There was a problem hiding this comment.
Looks good to me. If you could address my comment that would be great!
test/android/app/src/androidTest/java/org/apache/cordova/unittests/BackButtonMultipageTest.java
Outdated
Show resolved
Hide resolved
raphinesse
changed the title
breautek
approved these changes
Oct 7, 2020
Contributor
|
PR forcefully closed when I rebased the PR branch with apache's master. Supposedly because there are no new commits however I still have the original change commit... looks like I'm going to have to open a new PR for it. I think this was caused because this original PR was linked to their master branch. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
Motivation and Context
Test code may contain undesirable duplication. Solutions are similar to those for normal code duplication as described by Fowler.
Removing duplication helps maintainability of the test.
Description
I applied extract method and defined constants for duplicate strings.
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))