[CB-6837][Android] Fix: leaked window when hitting back button while alert being rendered #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alert being rendered
Use CordovaWebView.handleDestroy() to destroy all dialogs, and remove any involvement of CordovaActivity.
Contributor
Author
There was a problem hiding this comment.
dlg.show(); can be added complete to the next line, avoiding variable creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created arrayList on ChromeClient that it will register all showed AlertDialog, using CordovaChromeClient class, this applies to AlertDialogs object, included messages, prompts and confirm AlertDialog objects.
When onDestroy() method is called on the CordovaActivity, it will perform a call to ChromeClient class to destroy all AlerDialogs objects registered on the arrayList.
This would perform a cleanup before the CordovaActivity is destroyed.
dlg.show() returns an AlertDialog object, to be added to the arrayList.
It can be:
dialogsManager.add(dlg.show());
But I think it looks cleaner as is already.
Tested on 4.2.2 & 4.4.2.