Fixed javascript not loading when activity restarted after exiting with Back button

[odbol]

I was having some issues with my app (local javascript SPA):

1. Start app. Everything works normally.
2. Press Back button to exit. Activity exits and is destroyed.
3. Start app again. Now the HTML shows up, but the Javascript never runs, so nothing works.
4. Press Home button, activity goes to background (with non-working Javascript).
5. Start app again. Now Javascript loads and resumes properly. Everything starts working.

This is on KitKat 4.4.4 on a Nexus 5. "KeepRunning" = "false" in the config file.

Pretty simple fix, once I could figure it out. Please let me know if this has other consequences; sorry I can't provide a test case; my app is quite huge.

[agrieve]

Created issue for this: https://issues.apache.org/jira/browse/CB-8146.

Nice job tracking this down! I'd go even one step further to what Joe said and claim that activityState isn't necessary at all. I'd guess whoever put it in there originally just didn't know about the isFinishing() getter :S.

Going to merge in your change so that you get some credit for tracking it down, then will refactor to just delete activityState.

[odbol]

Actually, I've since found that this is not the best solution - it introduces another bug. Please do not merge.

I have found a better fix; I can try to publish that within the next few days.

[agrieve]

Alright, will hold off then.

[agrieve]

Please reference CB-8146 if with your better fix 👍