Skip to content

Conversation

@jpchase
Copy link
Contributor

@jpchase jpchase commented Mar 25, 2015

No description provided.

@clelland
Copy link
Contributor

It seems so small now.. only 17 changes :)

@jsoref
Copy link
Contributor

jsoref commented Mar 26, 2015

@jpchase: https://github.com/apache/cordova-android/compare/master...jsoref:pr/167?expand=1

Please consider folding in these changes (I can't seem to make a pull request against your repo)

@jpchase
Copy link
Contributor Author

jpchase commented Mar 27, 2015

@jsoref I included some of the corrections from your changes. I believe the release notes read better with less formatting, so I excluded many of your changes. Finally, I didn't link to the Whitelist Guide as I wasn't sure which would be the correct link, and I didn't want to link to the edge docs (as that wouldn't make sense over time).

@jsoref
Copy link
Contributor

jsoref commented Mar 27, 2015

It might be good to get an answer for the Whitelist Guide -- that seems useful to have.

Also, I'd personally encourage you to fold your changes together, there's no real need for people to see the intermediate changes.

@asfgit asfgit closed this in e904bab Mar 27, 2015
keianhzo pushed a commit to ludei/cordova-android that referenced this pull request Apr 7, 2015
* cordova_official/master:
  CB-8484 Add signing flags to `build` and `run` scripts
  CB-8781 Add building of .so files within libs/ to gradle rules
  CB-8548 Allow ant-style property key for key.store.type
  CB-8768 Fix onActivityResult called before plugins are loaded (after MainActivity gets killed)
  Fix lint errors breaking travis CI
  CB-8717 Add note to releasenotes about removal of hidekeyboard and showkeyboard events
  CB-8717 Add OkHttp removal to RELEASENOTES
  CB-8717 Tweak RELEASENOTES.md
  CB-8717 Write cordova-android@4.0.0 release notes (close apache#167)
  CB-8764 Store serviceName instead of class (close apache#169)
  CB-8764 Save instanceState before calling super
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants