cdvBuildMultipleApks casting fixed#199
Closed
mlegenhausen wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Casting `cdvBuildMultipleApks` via `!!` does not work when you want to modify the build process via the command line. The problem can be simply reproduced when running: `cordova build android -- --gradleArg=-PcdvBuildMultipleApks=false`. The expected output would be a build with a single apk. But the result is a build with multiple apks cause `!!"false"` is `true`. This fix solves the problem by using an more mature casting process that also can handle string that contain the value `"false"`.
Contributor
Author
|
I found a workaround: |
Member
|
Created JIRA: https://issues.apache.org/jira/browse/CB-9391 LGTM, merging. @mlegenhausen, if you're going to contribute to Apache projects, please sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas |
infil00p
pushed a commit
to infil00p/cordova-android
that referenced
this pull request
Aug 28, 2015
mbektchiev
pushed a commit
to Icenium/cordova-android
that referenced
this pull request
Dec 15, 2015
mbektchiev
pushed a commit
to Icenium/cordova-android
that referenced
this pull request
Dec 15, 2015
mbektchiev
pushed a commit
to Icenium/cordova-android
that referenced
this pull request
Dec 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting
cdvBuildMultipleApksvia!!does not work when you want to modify the build process via the command line. The problem can be simply reproduced when running:cordova build android -- --gradleArg=-PcdvBuildMultipleApks=false. The expected output would be a build with a single apk. But the result is a build with multiple apks cause!!"false"istrue. This fix solves the problem by using an more mature casting process that also can handle string that contain the value"false".