Skip to content

Conversation

@ShubhamUnique
Copy link

checking for console object and console.log functions before logging messages to handle cases in which such as window.console.log = console.log = null

Platforms affected

cordova-android

What does this PR do?

fixes console.log is not a function errors In projects where window.console.log = console.log = null

What testing has been done on this change?

the fix is manually tested by performing changes in an android app

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

checking for console object and console.log functions before logging messages to handle cases in which such as window.console.log = console.log = null
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6fa16b6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #409   +/-   ##
=========================================
  Coverage          ?   42.89%           
=========================================
  Files             ?       17           
  Lines             ?     1688           
  Branches          ?      307           
=========================================
  Hits              ?      724           
  Misses            ?      964           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa16b6...d369dc6. Read the comment docs.

@infil00p
Copy link
Member

This actually belongs here: https://github.com/apache/cordova-js

@infil00p infil00p closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants