Closed
Conversation
This unifies the config.xml used by iOS and Android. Now <feature> tags can be used to add plugins. The changes are non-intrusive so the older versions of the config.xml can still be used after this change. The value of a param named "android-package" determines the class for the plugin.
framework/res/xml/config.xml
Outdated
Contributor
There was a problem hiding this comment.
I don't think we can have dashes in the id here, as this should be used as the id for the application, which, in turn, needs to be a Java package name.
id used as package name on at least android. Changing the template config.xml to be compatible
Contributor
Author
|
Changed the template config.xmls id to be compatible with Java identifiers |
Remove the iOS specific values from the android project's template.
Contributor
|
Woohoo! Finally pulled this in! Please close this pull request for us. |
Contributor
Author
|
Great... One down, two more to go... Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unifies the config.xml used by iOS and Android. Now tags can be used
to add plugins. The changes are non-intrusive so the older versions of the config.xml
can still be used after this change. The value of a param named "android-package"
determines the class for the plugin.
Resolves
https://issues.apache.org/jira/browse/CB-1109
https://issues.apache.org/jira/browse/CB-1108
for Android