Skip to content

Conversation

@jcesarmobile
Copy link
Member

Platforms affected

Android

What does this PR do?

Fix the location of the config.xml so cdvHelpers.getConfigPreference works

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   43.91%   43.91%           
=======================================
  Files          17       17           
  Lines        1710     1710           
  Branches      317      317           
=======================================
  Hits          751      751           
  Misses        959      959

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24ba41...e1c3b4f. Read the comment docs.

@macdonst
Copy link
Member

macdonst commented Jan 2, 2018

@jcesarmobile it looks good to me. I haven't done any testing so I'm assuming that cordova-android uses platforms/android/app as the base directory.

@infil00p infil00p merged commit b3c262c into apache:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants