Skip to content

Conversation

@deton
Copy link
Contributor

@deton deton commented Jan 2, 2018

Platforms affected

Android

What does this PR do?

Fix problem that JavaScript receives ""(empty string) instead of null
if plugin sends null result from new thread.

What testing has been done on this change?

npm test

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Fix problem that JavaScript receives ""(empty string) instead of null
if plugin sends null result from new thread.
@codecov-io
Copy link

Codecov Report

Merging #425 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   43.91%   43.91%           
=======================================
  Files          17       17           
  Lines        1710     1710           
  Branches      317      317           
=======================================
  Hits          751      751           
  Misses        959      959

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24ba41...45a7b90. Read the comment docs.

@infil00p
Copy link
Member

infil00p commented Jan 3, 2018

LGTM, Merging!

@infil00p infil00p merged commit fcf705e into apache:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants