Keep Android Splashscreen image aspect ratio instead of stretching it.#43
Closed
steren wants to merge 1 commit intoapache:masterfrom
joshfire:master
Closed
Keep Android Splashscreen image aspect ratio instead of stretching it.#43steren wants to merge 1 commit intoapache:masterfrom joshfire:master
steren wants to merge 1 commit intoapache:masterfrom
joshfire:master
Conversation
An ImageView is used to be able to use ScaleType.CENTER_CROP, which is similar to the background-size:cover CSS property
Contributor
|
Thanks Steren! I've merged in your change: And updated the relevant bug: https://issues.apache.org/jira/browse/CB-1367 Please close the pull request. |
Contributor
Author
|
Thanks for the merge. |
Contributor
|
This change just got reverted because it broke apps that use 9-patch images for splash screens. If you think there is still merit in this approach, please chime in on https://issues.apache.org/jira/browse/CB-3337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Android device screens are all different, we cannot consider that one splashscreen dimension will fit them all. Currently, the code stretches it, and the image can lose its aspect ratio, which is bad for logo or other graphical designs.
An ImageView is used to be able to use ScaleType.CENTER_CROP, which is similar to the background-size:cover CSS property