Skip to content

Conversation

@ikram1983
Copy link

@ikram1983 ikram1983 commented Feb 16, 2020

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@dpogue
Copy link
Member

dpogue commented Feb 16, 2020

Could you give some background as to what problem this PR is trying to solve? The Android WebView has native websocket support already that is usable by Cordova applications

@dpogue dpogue added the info-needed / awaiting response Further information is requested label Feb 16, 2020
@breautek
Copy link
Contributor

Thank you for your contribution, but is PR cannot be accepted for a few different reasons:

  • Android webview already has support for web sockets.
  • The licenses are not valid for the apache project. You can't just copy other peoples code. Original Code
  • The implementation of this web socket doesn't appear to be updated to the latest standard, it appears to be based on an older draft.

If there was a bug that this PR was attempting to solve, I'd advise opening up a bug ticket first

@breautek breautek closed this Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info-needed / awaiting response Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants