Set the Android orientation based on config prefs. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Contributor
|
Merged! Thanks! Please close the pull request. |
|
This still doesn't work in Cordova CLI 3.4.0-0.1.3. I have Is there a specific version I need to be using? |
Member
Author
|
I belive that's because of a bug in the released version of cordova-cli that causes it to not update preferences (with an error message like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that the
Orientationpreference in config.xml should apply to all platforms, but this was not true for Android.This pull request causes the orientation specified in config.xml to be applied to the AndroidManifest.xml file as part of
cordova prepare.