Move e2e tests into spec overwriting duplicate tests. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the duplicate tests first as a separate commit (for better history).
Part 2, move all the files and delete e2e dir. For history of old overwritten tests in spec try git log 5cf9d90
After e2e dir was merged into spec/ there were interferences between the e2e tests and cli.spec.js. Jasmine runs all tests in a single process, therefore process-global settings like event listener (un)registration can cause interference between the tests. github: close apache#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging e2e tests into spec/ dir and removing the old duplicate tests as discussed in
https://www.mail-archive.com/dev@cordova.apache.org/msg15466.html