Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 29, 2013

...ding

@agrieve
Copy link
Contributor

agrieve commented Dec 5, 2013

Sometimes it is downloading, so I think it's good to say so.
Perhaps the best fix here is to print "downloading" only when about to download, and then print "installing" upon calling bin/create on the platform.

@jsoref
Copy link
Contributor Author

jsoref commented Dec 9, 2013

With changes, here is some output to consider:

Not Cached (verbose)

Requesting {"uri":"https://git-wip-us.apache.org/repos/asf?p=cordova-firefoxos.git;a=snapshot;h=3.2.0;sf=tgz"}...
Downloading cordova library for firefoxos...
Downloaded, unzipped and extracted 7348319 byte response.
Download complete
Installing cordova library for firefoxos...
Checking if platform "firefoxos" passes minimum requirements...
Creating firefoxos project...
Running bin/create for platform "firefoxos" with command: ""/Users/jsoref/.cordova/lib/firefoxos/cordova/3.2.0/bin/create"  "/private/tmp/hello/platforms/firefoxos" "io.cordova.hellocordova" "HelloCordova"" (output to follow)
Creating Firefox OS project
Project Path platforms/firefoxos
Package Name io.cordova.hellocordova
Project Name HelloCordova

cordova library for "firefoxos" already exists. No need to download. Continuing.
Generating config.xml from defaults for platform "firefoxos"
Calling plugman.prepare for platform "firefoxos"
Preparing firefoxos project
Processing configuration changes for plugins.
Iterating over installed plugins: []
Writing out cordova_plugins.js...

Cached (verbose)

cordova library for "firefoxos" already exists. No need to download. Continuing.
Checking if platform "firefoxos" passes minimum requirements...
Creating firefoxos project...
Running bin/create for platform "firefoxos" with command: ""/Users/jsoref/.cordova/lib/firefoxos/cordova/3.2.0/bin/create"  "/private/tmp/hello/platforms/firefoxos" "io.cordova.hellocordova" "HelloCordova"" (output to follow)
Creating Firefox OS project
Project Path platforms/firefoxos
Package Name io.cordova.hellocordova
Project Name HelloCordova

cordova library for "firefoxos" already exists. No need to download. Continuing.
Generating config.xml from defaults for platform "firefoxos"
Calling plugman.prepare for platform "firefoxos"
Preparing firefoxos project
Processing configuration changes for plugins.
Iterating over installed plugins: []
Writing out cordova_plugins.js...

Not Cached

Creating firefoxos project...
Generating config.xml from defaults for platform "firefoxos"
Preparing firefoxos project

Is this what you'd want? If so, I can squish them together...

@agrieve
Copy link
Contributor

agrieve commented Dec 13, 2013

LGTM! I'll squish when merging.

@agrieve
Copy link
Contributor

agrieve commented Dec 13, 2013

Merged! Thanks!

Please close the pull request.

@jsoref jsoref closed this Dec 13, 2013
@jsoref jsoref deleted the cb_5223 branch December 13, 2013 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants