Remove ZeroClipBoard to remove flash from docs #1032
Conversation
dblotsky
left a comment
dblotsky
left a comment
There was a problem hiding this comment.
This was 100% for the “copy” buttons. I don’t recall now why JS-only wasn’t enough at the time. Please validate on at least Ubuntu, macOS, and Windows on some modern set of browsers.
There was a problem hiding this comment.
Approved on my part.
Seems to basically use the existing fallback for no working flash, which has evidently already been working on Linux and other platforms with no flash-enabled browser.
Easiest to check with diff with no space changes: https://github.com/apache/cordova-docs/pull/1032/files?utf8=%E2%9C%93&diff=unified&w=1
P.S. See this guide for reference: https://github.blog/2018-05-01-ignore-white-space-in-code-review/
NiklasMerz
left a comment
NiklasMerz
left a comment
There was a problem hiding this comment.
I just did a quick test on Windows 10 and macOS Mojave with these browsers Firefox, Chrome, Internet Explorer, Safari. Looking good for me.
3 participants
This PR removes the ZeroClipBoardLibrary and moves the clipboard buttons to the native JS API.
Closes #1031