Skip to content

Conversation

@breautek
Copy link
Contributor

@breautek breautek commented Feb 7, 2021

Platforms affected

Blog

Motivation and Context

Annoucement of wkwebview plugin deprecation

Description

Testing

N/A

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary


## Deprecation of the Cordova WKWebView Engine Plugin

We are hereby annoucing the deprecation of [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/README.md#deprecation-notice).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need at least one more sentence of explanation here, saying that the plugin is built-in to cordova-ios 6 and no longer necessary, and that's why it's being deprecated.

We probably also want to encourage upgrading to cordova-ios 6 rather than just recommending the removal of the plugin after upgrading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some more details, but I didn't do it here, I did it in the 3rd paragraph. I felt like the post was a bit unorganised otherwise.

Please let me know what you think.

@breautek breautek force-pushed the deprecate-wkwebview-engine branch from 0648152 to d8278ab Compare February 8, 2021 00:17
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@breautek breautek merged commit 88b5696 into apache:master Feb 8, 2021
@breautek breautek deleted the deprecate-wkwebview-engine branch February 8, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants