CB-10347: Remove 'Add icons and splash screen' article #511
Conversation
www/docs/en/dev/config_ref/images.md
Outdated
| <icon src="res/ios/icon.png" platform="ios" width="57" height="57" density="mdpi" /> | ||
|
|
||
| src: (required) specifies the location of the image file, relative to your project directory | ||
| Attribute | Requirement | Description |
There was a problem hiding this comment.
The requirement information should be listed in the description column. See the example here: https://github.com/apache/cordova-docs/blob/master/doc/docs-STYLEGUIDE.md#xml-references
|
@riknoll Fixes added for your comment. |
www/docs/en/dev/config_ref/images.md
Outdated
| blackberry10 | ||
|
|
||
| # Splashscreen Plugin | ||
| The splash screen configuration information could be found at [Splashscreen plugin docs][splashscreen_plugin]. |
There was a problem hiding this comment.
Grammar:
Additional splash screen configuration options can be found in the Splashscreen Plugin docs
Icons page cleanup
|
@riknoll Changed that line. Not adding 'additional' there. As there is no splashcreen information prior to the line |
|
LGTM! |
|
@daserge Can you please review? As per the splashscreen plugin docs, I do not see it has the docs that you just deleted. Do you have another task to track that? |
| </platform> | ||
|
|
||
| BlackBerry10 | ||
| ##BlackBerry10 |
There was a problem hiding this comment.
Nitpick: for consistency with other headings, please add a space after the #s.
|
@sarangan12, do you plan to move splashscreen-related configuration docs to cordova-plugin-splashscreen? |
|
@daserge As part of plugin pull task, the details are already available on the readme file of splashscreen plugin and available in our site. The link (in the current page) point to it. |
|
@sarangan12, I looked but was not able to find |
|
@daserge Link: https://github.com/apache/cordova-plugin-splashscreen/blob/master/README.md This file is downloaded to the site. Agreed that this does not have examples. I will create a JIRA task to add examples to this README.me |
|
Thank you! 😄 |
…pache#511 Icons page cleanup
6 participants
Icons page cleanup
@nikhilkh @rakatyal @dblotsky Can you please review and merge this PR?