Skip to content

CB-12896: (ios) Update icon mapping#341

Merged
surajpindoria merged 1 commit intoapache:masterfrom
surajpindoria:icons
Oct 4, 2017
Merged

CB-12896: (ios) Update icon mapping#341
surajpindoria merged 1 commit intoapache:masterfrom
surajpindoria:icons

Conversation

@surajpindoria
Copy link
Member

@surajpindoria surajpindoria commented Sep 28, 2017

Platforms affected

iOS

What does this PR do?

Updates the mapped icons to include newer devices and screen resolutions

What testing has been done on this change?

Added all available icons to a project, opened in Xcode and checked the Images.xcassets file to make sure all icons were included.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

codecov-io commented Sep 28, 2017

Codecov Report

Merging #341 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files          14       14           
  Lines        1690     1690           
  Branches      283      283           
=======================================
  Hits         1072     1072           
  Misses        618      618
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 84.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b162750...7b7964f. Read the comment docs.

@surajpindoria surajpindoria merged commit 7b7964f into apache:master Oct 4, 2017
@surajpindoria surajpindoria deleted the icons branch October 5, 2017 23:28
@briantobo
Copy link

This update broke the 80x80 icon (icon-40@2x.png). It does not copy the file anymore and fallbacks to the default cordova icon instead.

@timbru31
Copy link
Member

Can we have a new release for this issue with the 80x80 icon? This breaks CI builds for us, since manual editing is required before a new app is built.

@surajpindoria
Copy link
Member Author

surajpindoria commented Oct 19, 2017

Yes, I can begin this process and have it released by next week. In the meantime, if you want to update your config.xml to use the master version of cordova-ios like so:
<engine name="ios" spec="https://github.com/apache/cordova-ios" />, that should get your CI back in order.

@timbru31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants