Skip to content

PodsJson.increment/decrement has a code error resulting in pods not being installed while specified#424

Merged
shazron merged 1 commit intoapache:4.5.xfrom
markmarijnissen:patch-1
Jan 9, 2019
Merged

PodsJson.increment/decrement has a code error resulting in pods not being installed while specified#424
shazron merged 1 commit intoapache:4.5.xfrom
markmarijnissen:patch-1

Conversation

@markmarijnissen
Copy link

Platforms affected

iOS

What does this PR do?

Fix an error in de the code (which can be seen through understanding the code logic)

What testing has been done on this change?

My cordova project did not install certain pods.
After making this change, the pods were installed.

@markmarijnissen markmarijnissen changed the title PodsJson.increment/decrement has an error PodsJson.increment/decrement has a code error resulting in pods not being installed while specified Oct 4, 2018
@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #424 into 4.5.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.5.x     #424   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files          14       14           
  Lines        1691     1691           
  Branches      284      284           
=======================================
  Hits         1073     1073           
  Misses        618      618
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/PodsJson.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8729e5...749eb5e. Read the comment docs.

@shazron
Copy link
Member

shazron commented Jan 9, 2019

Added issue for adding the test #493

@shazron shazron merged commit 253c0c1 into apache:4.5.x Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants