Skip to content

Add comment section at end of build.gradle#117

Closed
fujunwei wants to merge 1 commit intoapache:CB-3445-2from
fujunwei:gradle-reference-2
Closed

Add comment section at end of build.gradle#117
fujunwei wants to merge 1 commit intoapache:CB-3445-2from
fujunwei:gradle-reference-2

Conversation

@fujunwei
Copy link
Contributor

@fujunwei fujunwei commented Nov 7, 2014

If a project already has a build.gradle file when upgrade Cordova, we should add the comment section automatically when install the plugin.

If a project already has a build.gradle file when upgrade Cordova,
we should add the comment section automatically when install the plugin.
@fujunwei
Copy link
Contributor Author

@agrieve @clelland PTAL. Thanks.

@fujunwei
Copy link
Contributor Author

@clelland What happens on upgrade, if a project already has a platforms/android/build.gradle file? Do we need to put some code in to either replace build.gradle or add the two guard lines in the right place? Or do we tell affected people to copy it or recreate their projects?

Add the two lines automatically when upgrade the project.

@fujunwei fujunwei closed this Nov 12, 2014
halton pushed a commit to halton/cordova-lib that referenced this pull request Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant