Skip to content

Use cp instead of mv, as it would fail if tmp_dir is mounted on a dif…#245

Closed
sencenan wants to merge 1 commit intoapache:masterfrom
LikeMindNetworks:master
Closed

Use cp instead of mv, as it would fail if tmp_dir is mounted on a dif…#245
sencenan wants to merge 1 commit intoapache:masterfrom
LikeMindNetworks:master

Conversation

@sencenan
Copy link
Contributor

Use cp instead of mv, as it would fail if tmp_dir is mounted on a different device from the plugin_dir. The tmp_dir is cleaned after copy already.

This fixes:

EXDEV, cross-device link not permitted '/tmp/git/1433949300428/Example'

when installing from git repository

…ferent device from the plugin_dir. The tmp_dir is cleaned after copy already.
@nikhilkh
Copy link
Contributor

@TimBarham @omefire to take a quick look

@omefire
Copy link
Contributor

omefire commented Jun 12, 2015

I'm trying to reproduce this error. @sencenan does this happen as well when you use different partitions of the same device ? or is it only on totally different devices ?

@sencenan
Copy link
Contributor Author

@omefire my workspace and /tmp are mounted on different hard drives.

Please also see this comment:

// Create a tmp dir. Using /tmp is a problem because it's often on a different partition and sehll.mv()

This is a known issue.

@omefire
Copy link
Contributor

omefire commented Jun 13, 2015

LGTM !

@asfgit asfgit closed this in 6600712 Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants