Use cp instead of mv, as it would fail if tmp_dir is mounted on a dif…#245
Closed
sencenan wants to merge 1 commit intoapache:masterfrom
Closed
Use cp instead of mv, as it would fail if tmp_dir is mounted on a dif…#245sencenan wants to merge 1 commit intoapache:masterfrom
sencenan wants to merge 1 commit intoapache:masterfrom
Conversation
…ferent device from the plugin_dir. The tmp_dir is cleaned after copy already.
Contributor
|
@TimBarham @omefire to take a quick look |
Contributor
|
I'm trying to reproduce this error. @sencenan does this happen as well when you use different partitions of the same device ? or is it only on totally different devices ? |
Contributor
Author
|
@omefire my workspace and /tmp are mounted on different hard drives. Please also see this comment: This is a known issue. |
Contributor
|
LGTM ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cp instead of mv, as it would fail if tmp_dir is mounted on a different device from the plugin_dir. The tmp_dir is cleaned after copy already.
This fixes:
when installing from git repository