Skip to content

:CB-13532 : updated to include a check for pkgJson devDependencies #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevengill merged 1 commit into from
Dec 11, 2017
Merged

:CB-13532 : updated to include a check for pkgJson devDependencies #607

stevengill merged 1 commit into from
Dec 11, 2017

Conversation

@audreyso
Copy link
Contributor

@audreyso audreyso commented Nov 8, 2017

Platforms affected

What does this PR do?

include a check for pkgJson devDependencies

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@dpogue
Copy link
Member

dpogue commented Nov 8, 2017

👍

Just to confirm the intention: Cordova will prefer versions listed in dependencies over devDependencies? That makes sense to me.

@stevengill stevengill merged commit 3109e4f into apache:master Dec 11, 2017
@dpogue dpogue mentioned this pull request Dec 19, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stevengill stevengill stevengill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@audreyso @dpogue @stevengill