Allow third-party plugin registration, and the total count of fs type is...

[lmnbeyond]

... not limited to just 4.

[lmnbeyond]

@clelland
If you're available, please review this PR!

BTW, I'm wondering should we provide an approach to request fs via file system's name?

[clelland]

There's really only one condition here -- could this be
if (!localURL || (index < [[object fsRoot] length])) {
to avoid duplicating the logic inside?

[clelland]

This is a change that I had definitely wanted to make -- it makes the file-system-roots plugin not dependent on the order of installed filesystems as well.

And I agree that we should provide an interface to select a filesystem by name. Right now you can do it by just constructing the URL manually, but that's pretty tightly coupled to the implementation.

[lmnbeyond]

@clelland Many thanks to you! I have updated the code to avoid duplicating logic inside, please review this again!

[clelland]

Looking at this code a bit more closely now, I think that this is the wrong comparison to make.

The fsRoot property is only a property of the CDVLocalFilesystem class, not CDVFilesystem. It is at least possible for other CDVFilesystem subclasses to implement URLforFilesystemPath: without having an fsRoot property, and in those cases, this code would throw an exception.

Maybe a better way to do this is to keep track of the fullPath property of the url variable (which will be present on any CDVFilesystemURL). That property will be shorter in all of the cases where fsRoot would be longer, so a shorter fullPath would imply that the filesystem is a better match for the local path.

What do you think of changing index into something like shortestFullPath, and testing whether

[[url fullPath] length] < shortestFullPath

?

[lmnbeyond]

Sorry for my mistakes! Your comment really makes sense. I have followed your advice and updated my PR, please review it again!

Many thanks for your time. :)

[clelland]

Merged! You can close this PR

I ported your code to the Android side as well, for parity. If you want to, check out 8b0ada7 -- I think that it's an accurate translation of your iOS code.