Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

BB10 implementation#18

Closed
bryanhiggins wants to merge 36 commits intoapache:masterfrom
blackberry-webworks:lyon-g11n
Closed

BB10 implementation#18
bryanhiggins wants to merge 36 commits intoapache:masterfrom
blackberry-webworks:lyon-g11n

Conversation

@bryanhiggins
Copy link
Member

Opening this for visibility. It needs to be squashed and .so files re-generated from the latest commit.

Lianghui Chen added 30 commits July 28, 2014 15:10
* It is just a wrapper and needs native side support to work.
* Steps to do:
  * File -> New -> BlackBerry Project -> Native Extension -> BlackBerry WebW
  * Project name: Globalization.
  * Build type: Managed (versus Makefile).
* All methods are now return a generic unsupported error.
* Just default value now, not sure how to apply options yet.
* Not working yet: getMonths/getWeekdays return null.
…value.

* The reason is calling resultInJson(const char*) will be mapped to
  resultInJson(bool), instead of resultInJson(const std::string&).
* Adding an explicit resultInJson(const char*) fixes this issue.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted

Bryan Higgins and others added 2 commits July 30, 2014 14:19
{
public: // overridden from ValueArrayAllocator
virtual ~DefaultValueArrayAllocator()
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp: accessign

* value. This provides a better compromise between memory usage and speed.
*
* Each bucket is made up of a chained list of ValueInternalLink. The last
* link of a given bucket can be found in the 'previous_' field of the following bucket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp: addional

if (!cal) {
slog2f(0, ID_G11N, SLOG2_ERROR, "GlobalizationNDK::getDateNames: unable to create Calendar instance: %x.",
status);
return errorInJson(UNKNOWN_ERROR, "Unable to create Calendar instance!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it curt to name this calDeleter? (it upsets my spell checker)

@bryanhiggins bryanhiggins deleted the lyon-g11n branch July 31, 2014 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments