Skip to content

Conversation

@paymicro
Copy link

In Linux, the callback is not called until the process terminates.
If the error is not caused within 2 seconds, then the promise will be resolved.

Platforms affected

  • Linux

What does this PR do?

What testing has been done on this change?

  • manual testing launching browsers in Linux, Windows and MacOs

purplecabbage added a commit to purplecabbage/cordova-serve that referenced this pull request Jun 29, 2017
@matrosov-nikita
Copy link

@paymicro, could you please fix jshint errors?

If the error is not caused within 2 seconds, then the promise will be resolved.
@stevengill
Copy link
Contributor

I believe my PR fixes the issue of promise not resolving. #4

Can you confirm @paymicro? If so, this PR & issue can be closed.

@stevengill
Copy link
Contributor

I'm going to mark this PR to be closed

@stevengill stevengill closed this Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants