This repository was archived by the owner on May 25, 2021. It is now read-only.
Account for binary keys for headers in CORS#39
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 1, 2015
Merged
Conversation
Contributor
Author
|
Fix typo in commit message |
Member
|
+1 after fixing typo "fir" in PR title and commit message. |
We do have headers' keys represented as either lists or binaries. Make sure we don't crash on `string:to_lower`. COUCHDB-2733
iilyak
force-pushed
the
2733-binary-cors-headers
branch
from
1eed9c5 to
9ddbd04
Compare
iilyak
changed the title
Contributor
Author
|
updated |
Member
|
+1 but could be +10 if we have some tests for this case (: |
Member
|
+1. @iilyak can you merge or do you need someone to do it? |
Contributor
Author
|
@rnewson: I don't have commit power. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do have headers' keys represented as either lists or binaries.
Make sure we don't crash on
string:to_lower.COUCHDB-2733