This repository was archived by the owner on May 25, 2021. It is now read-only.
2898 improve global changes tests#129
Merged
asfgit merged 3 commits intoNov 24, 2015
Merged
Conversation
This supports downstream name munging that might occur COUCHDB-2898
Downstream builds automatically ensure _global_changes exists, so this commit works for both cases COUCHDB-2898
Member
|
Don't you actually hide an issue with e7b3ba4 commit? Slash character is used by global_changes for specific logic owner. |
Contributor
Author
|
Yes, it's possible that there's a bug downstream that's triggered by the "/" in the db name. It works correctly for one of the downstream builds, but fails in the other. @kxepal, if you prefer, I can omit that commit. |
Member
|
I think you should omit that commit in order to not forget about the bug and fix it in downstream (: There is no better reminder as build failure. |
COUCHDB-2898
jaydoane
force-pushed
the
2898-improve-global-changes-tests
branch
from
a2e6dc9 to
bc071d7
Compare
Contributor
Author
|
@kxepal, I've removed the offending commit. |
Member
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.