This repository was archived by the owner on May 25, 2021. It is now read-only.
Propagate db delete event to changes callback#139
Merged
asfgit merged 2 commits intoFeb 17, 2016
Conversation
Member
|
Ahhh, took me two readings of your commit message before I put the whole thing together. I kept trying to figure out how we introduced the bug during the merge and got confused by the work on view changes. Rereading your commit message it appears to not be a new bug, just one we hadn't noticed yet. +1 |
Member
|
I looked at that test failure and it appears unrelated, but we might also want to verify that as well. |
Member
|
+1 |
iilyak
force-pushed
the
should_end_changes_when_db_deleted
branch
from
d6f5bb7 to
4e6d2d6
Compare
Not propagating the `delete` event to the changes callback causes db to stay open when it is deleted in the presence of `continuous` requests to _changes feed. This in its turn causes couch_file to stay open until the connection is closed by the client.
While working on the issue test suite was re-enabled. It passes locally. However one of the test cases fails in other environments so commenting out that flaky test for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not propagating the
deleteevent to the changes callback causesdb to stay open when it is deleted in the presence of
continuousrequests to
_changesfeed. This in its turn causescouch_fileto stayopen until the connection is closed by the client.