This repository was archived by the owner on May 25, 2021. It is now read-only.
Closed
Conversation
Based on this [article](http://robert-kowalski.de/blog/lets-learn-erlang-and-fix-a-bug-on-a-couchdb-cluster/), the function is ensuring that a username is returned. Just removed the "not" from the test function name.
alanning
referenced
this pull request
in robertkowalski/couchdb-couch
Aug 1, 2015
When logging in with admin credentials and no user doc is
present, the name was `null`. Example:
`{"ok":true,"name":null,"roles":["_admin"]}`
closes COUCHDB-1356
Member
|
thanks for the patch! :) did the testsuite work for you? I think https://github.com/alanning/couchdb-couch/blob/ca9af59663fdc42f53d0850e4b1bc1e4c4e6dff5/test/couchdb_auth_tests.erl#L37 also needs a change (list of tests that are going to run) |
Member
|
Agree with @robertkowalski - test suite will fail because of unknown test function. |
Author
|
Ah, thanks! I made the change purely through github's interface and didn't realize there was a separate list of tests. Travis CI was showing "pending..." when I created the PR; I should have let it run to completion. |
Author
|
Hmm, TravisCI tests still failing but it seems unrelated. "No Rakefile found". |
Member
|
Ignore travis by now. LGFM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this article, the function is ensuring that a username is returned. This change just removes the "not" from the test function name.