Skip to content

Speed up startup time, fixes #131#144

Merged
wohali merged 1 commit intomasterfrom
speedup-startup
Apr 30, 2019
Merged

Speed up startup time, fixes #131#144
wohali merged 1 commit intomasterfrom
speedup-startup

Conversation

@wohali
Copy link
Copy Markdown
Member

@wohali wohali commented Apr 30, 2019

See #132 - this is the revised version.

Already +1 by @kocolosk .

@wohali wohali mentioned this pull request Apr 30, 2019
3 tasks
@kocolosk
Copy link
Copy Markdown
Member

Nice, thanks for cleaning this up @wohali

@wohali wohali merged commit 764b79a into master Apr 30, 2019
@wohali wohali deleted the speedup-startup branch April 30, 2019 21:31
@arturog
Copy link
Copy Markdown

arturog commented Oct 3, 2019

@wohali: Hello, I am a bit confused by this commit/PR. Are we setting all files under /opt/couchdb as owned by the running process (couchdb)? I feel we should get binaries, etc, to be owned by root.

Can you point me in the right direction to understand why this was necessary? Thanks!

@wohali
Copy link
Copy Markdown
Member Author

wohali commented Oct 4, 2019

If the data and config files aren't owned by couchdb then the database won't function correctly.

@arturog
Copy link
Copy Markdown

arturog commented Oct 4, 2019

Understood, but the commands in the Dockerfile and docker-entrypoint.sh are setting all files under /opt/couchdb to be owned by the couchdb user -that can't be right.

I think we should only set ownership on /opt/couchdb/data, logs, etc... Otherwise the running process has permissions to write over the binaries. Shall we fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants