Skip to content

Improve README for configuration changes, closes #47#65

Merged
wohali merged 1 commit intomasterfrom
update-readme
Apr 9, 2018
Merged

Improve README for configuration changes, closes #47#65
wohali merged 1 commit intomasterfrom
update-readme

Conversation

@wohali
Copy link
Copy Markdown
Member

@wohali wohali commented Jan 31, 2018

Overview

README.md was misleading on the desired approach for making configuration changes, leading to PRs like #32. This makes it clearer that if you need more than you can get from a few simple env vars, you should be mounting /opt/couchdb/etc/local.d as a volume and persisting it to disk.

By specifying the local.d subdirectory we ensure that upstream image default changes to /opt/couchdb/etc/default.ini, as well as docker-specific upstream changes in /opt/couchdb/etc/default.d, are unaffected by externalisation of this volume.

Testing recommendations

Read it!

GitHub issue number

Closes #47

Checklist

  • Documentation reflects the changes;

@wohali
Copy link
Copy Markdown
Member Author

wohali commented Jan 31, 2018

One weakness of this approach is that it means you cannot externalise /opt/couchdb/etc/vm.args.

I am torn on this point. There are parameters in there (like the erlang cookie) that would be good to persist.

However, externalising the entire /opt/couchdb/etc directory prevents us from slipstreaming changes to default.ini and default.d/* into the image successfully.

Perhaps we just add a new env var just for ERLANG_COOKIE and wipe our hands of it.

@chriswiggins
Copy link
Copy Markdown

chriswiggins commented Jan 31, 2018

The issue with not being able to expose vm.args is that there are other things that cannot be changed. We run a RabbitMQ Cluster on the same hosts as our CouchDB cluster, which means that we need to change the epmd port. We also changed the node name too.

I think with docker that it's possible to bind-mount files as well as directories isn't it? Might be something to suggest as well 👍

@wohali
Copy link
Copy Markdown
Member Author

wohali commented Feb 1, 2018

Looks like as long as you're not on Windows, you can bind-mount a single file. I'll update.

Any other comments?

@wohali wohali merged commit fd69b25 into master Apr 9, 2018
@wohali wohali deleted the update-readme branch April 9, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants