Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

POST /dbname should not return ETag response header#139

Merged
wohali merged 2 commits into
masterfrom
620-doc-post-etag
Jul 19, 2017
Merged

POST /dbname should not return ETag response header#139
wohali merged 2 commits into
masterfrom
620-doc-post-etag

Conversation

@rnewson
Copy link
Copy Markdown
Member

@rnewson rnewson commented Jul 4, 2017

as it relates to a different resource.

Note: We used to send ETag for this in previous releases, so it's
technically a regression even though we accidentally fix a spec
violation.

Closes apache/couchdb#620

as it relates to a different resource.

Note: We used to send ETag for this in previous releases, so it's
technically a regression even though we accidentally fix a spec
violation.

Closes #620
@wohali
Copy link
Copy Markdown
Member

wohali commented Jul 4, 2017

You should also document this in https://github.com/apache/couchdb-documentation/blob/master/src/whatsnew/2.0.rst as a breaking change.

You probably also want to say " Closes apache/couchdb#620 " since this repo doesn't have an issue #620. :)

@wohali
Copy link
Copy Markdown
Member

wohali commented Jul 4, 2017

Oh, +1 once the 2.0.rst is updated.

@rnewson
Copy link
Copy Markdown
Member Author

rnewson commented Jul 4, 2017

you mean whatsnew/2.1rst?

@rnewson
Copy link
Copy Markdown
Member Author

rnewson commented Jul 4, 2017

2.1.0.rst refers to the scheduler, which isn't present...

@wohali
Copy link
Copy Markdown
Member

wohali commented Jul 4, 2017

As discussed on IRC:

13:49 <+Wohali> rnewson: 2.0 is what you want to put it in, because it's
                changed behaviour in the 2.0 release. We will have to change
                the repo for the scheduler stuff, jan didn't fork that repo
                before it landed. Or we will fork it earlier and cherry pick.
                and make commits ot master that move the scheduler changes to a
                2.2 or similar, unless there is agreement it can land in 2.1 in
                the next couple of weeks

@wohali
Copy link
Copy Markdown
Member

wohali commented Jul 19, 2017

Taking this one as @rnewson is out of cycles right now.

@wohali wohali self-assigned this Jul 19, 2017
@wohali wohali merged commit b772caa into master Jul 19, 2017
@wohali wohali deleted the 620-doc-post-etag branch July 19, 2017 19:08
jiangphcn pushed a commit to cloudant/couchdb-documentation that referenced this pull request Mar 16, 2018
* POST /dbname should not return ETag response header

as it relates to a different resource.

Note: We used to send ETag for this in previous releases, so it's
technically a regression even though we accidentally fix a spec
violation.

Closes apache#620

* Document loss of ETag in POST as breaking change in 2.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POST and ETag header

2 participants