Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

Conversation

@kapoormanish
Copy link

Overview

Testing recommendations

GitHub issue number

Related Pull Requests

Checklist

  • Documentation is written and is accurate;
  • make check passes with no errors
  • Update rebar.config.script with the commit hash once this PR is rebased and merged

@flimzy
Copy link
Member

flimzy commented Sep 12, 2017

Thanks for your contribution. Two observations:

  1. The change introduces trailing whitespace which is prohibited by the build scripts:

     /home/travis/build/apache/couchdb-documentation/src/intro/tour.rst
       line 245 : trailing whitespace detected!
    
  2. There's no actual grammatical mistake. "Take some getting used to" is a common idiomatic expression (at least in American English). Although having said that, I would not be surprised if a large number of non-native speakers wouldn't know this, and your addition of the word "time" alleviates any ambiguity without substantially changing the meaning. So while I don't consider it a mistake, I approve the spirit of the change. :)

@wohali wohali closed this Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants