Conversation
These are just small, easy, hopefully non-controversial grammar fixes. The definition of URI refers to RFC 2396. But RFC 2396 is obsolete. It has been replaced by RFC 3986. RFC 2822 has been obsoleted and replaced with RFC 5322
|
Thanks a lot for your fixes! However, this change causes breaks style guidlines in many ways. Here is a full list of problems: Once they'll be fixed, I merge your PR with pleasure! |
|
You may rebase your PR against current master to let Travis CI check all the bits. |
|
I am running on windows and I tried make.bat doctest from the src directory but got a failure because it says "Build name doctest not registered". Eventually I figured out how to manually just run "python ext\linter.py src" from the MakeFile and that worked. But in any case it would be useful to have a link in the style guide that explains how to run the linter. I'm going to close this PR and submit a separate one from my new repo. I fixed all the linter issues so hopefully now it will be fine. |
|
@yaronyg good points. I'll add reference to linter and fix windows support as well. Thanks! |
These are just small, easy, hopefully non-controversial grammar fixes.
The definition of URI refers to RFC 2396. But RFC 2396 is obsolete. It has been replaced by RFC 3986.
RFC 2822 has been obsoleted and replaced with RFC 5322