Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

Conversation

@mar-ia
Copy link
Contributor

@mar-ia mar-ia commented Apr 12, 2015

This is basically my couchdb-crazy rep, converted and modified.
The documentation is not done with this, but it is a base to build on.

This is all I have on 2.0, so if anyone wants to fork this branch and continue building on it before merging, please do so :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to explicitly how here that data, shards and others are directories? Like:

data/
+-- shards/
     +-- 00000000-7fffffff/
     |   +-- small.1425202577.couch
     +-- 80000000-ffffffff/
         +-- small.1425202577.couch

@kxepal
Copy link
Member

kxepal commented Apr 12, 2015

That's great contribution! Again (:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't try now - but is it PUT or GET?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, /_membership accepts only GET

@sebastianrothbucher
Copy link

this is just GREAT - definitely +1 on merging it in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example could be pretty printed.

@janl
Copy link
Member

janl commented Apr 14, 2015

Great work @mar-ia! Let’s get this merged and file issues for the line-comments to fix soon after.

@kxepal
Copy link
Member

kxepal commented Apr 14, 2015

@janl why not to fix them before? since they are pretty trivial.

@mar-ia
Copy link
Contributor Author

mar-ia commented Apr 14, 2015

And already fixed :)
I did some more fixes and some rewrites too, in a try to make things more clear.

@kxepal
Copy link
Member

kxepal commented Apr 14, 2015

@mar-ia great! Could you only squash your commits please. If you think it's ready, I'll merge it.

@janl
Copy link
Member

janl commented Apr 14, 2015

@kxepal all I meant: I don’t think these are blockers. We can always fix them before, too. Sorry for being unclear :)

@mar-ia
Copy link
Contributor Author

mar-ia commented Apr 14, 2015

Squashed.
@kxepal Please do :)

@asfgit asfgit merged commit 51fccc8 into apache:master Apr 14, 2015
@kxepal
Copy link
Member

kxepal commented Apr 14, 2015

Thank you! (:

@mar-ia mar-ia deleted the cluster branch April 14, 2015 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants