Fix bashism in Makefile

[micah]

The [[ operator is a bashism, and fails with POSIX shells (such as dash), replace it with a simplier version that does the same thing, without the unnecessary $(shell) nesting.

[rnewson]

not sure why you didn't edit the original PR but note for future that we prefer it if comments are addressed in the same place.

[rnewson]

+1 from me (@kxepal, thoughts?)

[kxepal]

This version doesn't works for me (bash):

$ make html
which: no sphinx-build in (/usr/local/bin:/usr/bin:/bin:/opt/bin:/usr/x86_64-pc-linux-gnu/gcc-bin/4.8.4:/usr/games/bin)
which: no null in (/dev)
*** Make sure that sphinx-build is  installed and on your path
Makefile:63: recipe for target 'sphinx-build' failed
make: *** [sphinx-build] Error 1

If I have sphinx-build installed:

 $ make html
/usr/local/opt/virtualenv/couchdb/bin/sphinx-build
which: no null in (/dev)
*** Make sure that sphinx-build is  installed and on your path
Makefile:63: recipe for target 'sphinx-build' failed
make: *** [sphinx-build] Error 1

[kxepal]

I guess, missed stdout redirection glyph is missed here.

[micah]

not sure why you didn't edit the original PR but note for future that we prefer it if comments are addressed in the same place

I'm not sure why I couldn't, I tried to use github's web interface to do it, but I'm a bit of a neanderthal when it comes to doing that. I also couldn't figure out how to quote you, so I just copy and pasted it.

[kxepal]

@micah thanks! please squash your commits.

[benkeen]

Could this be causing a couchdb installation failure?

• Fresh clone of couchdb
• run ./configure
• run make. Result:

*** Make sure that sphinx-build is installed and on your path
make[1]: *** [sphinx-build] Error 1
make: *** [src/docs/build] Error

Same error for the next sudo make install step. Running ./dev/run seems to work fine, but Fauxton won't load up at all - all requests to the server just timeout.

[kxepal]

@micah ping

[kxepal]

@benkeen that's lack of python sphinx: you don't have it installed, so build fails on docs. However, they shouldn't and cannot block Fauxton as they builds the last and even broken docs are not a problem for Fauxton.

[benkeen]

I see, thanks @kxepal.

[micah]

I can't squash my commits, because I used the github web editor to make them. That was an experiment I wont repeat.

I made a new pull request, using the normal and proper way, so I'll close this one and you can use that one instead: #34

[kxepal]

@micah Actually, you can control this PR via patch-2 branch which is located in your fork. Any modifications there will be reflected here.

[kxepal]

Github webeditor is just shortcut for: fork, create patch-N branch, commit and create PR - and all in your browser.

[micah]

@kxepal The thing is, I didn't have a fork at all... I went and forked it to make this last pull request, and there was no patch-2 branch there either. 🍤

[kxepal]

@micah no, you have https://github.com/micah/couchdb-documentation/tree/patch-2 P: