This repository was archived by the owner on Oct 17, 2022. It is now read-only.
Conversation
Documents the `stats.interval` configuration key and remove the redundant `rate` and `samples` keys. Additionally, adds a note about how `histogram` types interact with the collection interval and how `_stats` should be safely consumed to avoid lossy sampling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Documents the
stats.intervalconfiguration key and removethe redundant
rateandsampleskeys.Additionally, adds a note about how
histogramtypes interactwith the collection interval and how
_statsshould be safelyconsumed to avoid lossy sampling.
Testing recommendations
n/a
GitHub issue number
Related Pull Requests
Checklist
make checkpasses with no errors