Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

Conversation

@mar-ia
Copy link
Contributor

@mar-ia mar-ia commented Nov 20, 2014

I got stuck on this, so adding a note to help the next me.

@rnewson
Copy link
Member

rnewson commented Nov 20, 2014

This is not the only place we do this, I think a note here is not sufficient.

@kxepal
Copy link
Member

kxepal commented Nov 20, 2014

This is already defined in resource description.

Update: reference is broken, see line 94:

  :>header Cache-Control: ``no-cache`` if changes feed is
    :ref:`eventsource <changes/eventsource>`
  :>header Content-Type: - :mimetype:`application/json`
                         - :mimetype:`text/event-stream`
                         - :mimetype:`text/plain; charset=utf-8`
  :>header ETag: Response hash is changes feed is `normal`
  :>header Transfer-Encoding: ``chunked`` 
  :>json number last_seq: Last change sequence number
  :>json array results: Changes made to a database
  :code 200: Request completed successfully
  :code 400: Bad request

@mar-ia
Copy link
Contributor Author

mar-ia commented Nov 20, 2014

Yes, it is already defined. I have been reading a lot about CouchDB and never seen chunked transfer encoding mentioned. This is the first place.
So I think that it needs to be mentioned in a more obvious way. The docs have been holding my hand so far, but here it let go.

@kxepal
Copy link
Member

kxepal commented Nov 20, 2014

@mar-ia it's defined for changes feed, views, db_updates, log and some other resources. I don't think it's need to be defined in some special way since this is a standard HTTP feature, not a some special case or a behaviour which is need to point on. Otherwise we'll have whole documentation full of notice boxes which will distract users from main content.

@mar-ia
Copy link
Contributor Author

mar-ia commented Nov 20, 2014

@kxepal Lets put it somewhere in 10.1. API Basics then.
How about in 10.1.2. HTTP Headers under Response Headers? :)

@kxepal
Copy link
Member

kxepal commented Nov 20, 2014

@mar-ia good idea.

@mar-ia
Copy link
Contributor Author

mar-ia commented Nov 24, 2014

Rewriting history, the first patch never happened :)
All the different transfer encodings used should be listed under 10.1.2. HTTP Headers: Response Headers.
The only used encoding I can find is chunked. If there are others encodings used, point them out and I will add them too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CouchDB is able to send all the data, but it doesn't known or won't to know how much of it will have to send e.g. it cannot set content length value.

@mar-ia
Copy link
Contributor Author

mar-ia commented Nov 24, 2014

Changed the wording a bit.
And added a link to changes feed, references are a good thing :)

@rnewson
Copy link
Member

rnewson commented Nov 25, 2014

+1

@kxepal
Copy link
Member

kxepal commented Nov 25, 2014

Squashed and merged. Thanks!

@asfgit asfgit closed this in 6f39c71 Nov 25, 2014
@mar-ia mar-ia deleted the note branch December 21, 2014 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants