Conversation
| function (app, FauxtonAPI, React, Stores, Actions, Components, Documents, FauxtonComponents, | ||
| ReactBootstrap, ReactSelect, ReactCSSTransitionGroup) { | ||
|
|
||
| require('react-select/dist/react-select.css'); |
Member
There was a problem hiding this comment.
Why not just add this to the other defines?
Member
|
+1 once tests pass. |
robertkowalski
force-pushed
the
react-15
branch
2 times, most recently
from
2f2cd47 to
73a5161
Compare
react-select is easier to extend and customize and it also supports rendering the result-list after a click. it also supports react 15 and is actively maintained.
robertkowalski
force-pushed
the
react-15
branch
from
73a5161 to
3bf72fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and upgrades for React 15