feat: allow configure persistentVolumeClaimRetentionPolicy#136
Merged
Conversation
willholley
requested changes
May 7, 2024
Member
willholley
left a comment
willholley
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you rebase on master? I'm happy to merge this (assuming tests pass), though it's probably worth adding a comment that this is a beta feature in Kubernetes so is generally unavailable. We may have to revisit this if/when this becomes GA.
Contributor
Author
done |
willholley
requested changes
May 7, 2024
Member
willholley
left a comment
willholley
left a comment
There was a problem hiding this comment.
thanks @ByJacob - can you increment the chart version?
Contributor
Author
done :) |
willholley
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow to specify a persistentVolumeClaimRetentionPolicy in both the primary and secondary StatefulSet.
Special notes for your reviewer:
This allows for automatic cleanup of PVCs after deletion, etc. An example use case of this is for highly dynamic test environments, where cleaning up the PVCs after deletion of the helm chart is preferred.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.